Support loading of translations on threads #78747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
the
cherrypick:4.1
|
Can confirm that this fixes #78689 for me |
|
I think this fix introduces a regression: registers as a translation of the locale |
|
Here's a MRP showing the regression: Note that this only happens when a translation is made with |
RandomShaper
force-pushed
the
fix_trans_threading
branch
from
bcf3058
to
5301bbb
Compare
|
I've updated the PR (including the description). Both cases should work now. |
|
This one would be good for 4.2 dev builds. |
YuriSizov
approved these changes
Jul 26, 2023
|
Thanks! |
|
Cherry-picked for 4.1.3. |
YuriSizov
removed
the
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resources can safely do deferred calls from threads in the context of resource loading. The
ResourceLoaderhas a mechanism in place to make them eventually run on the main thread, safely. With this PR, the patched call can benefit from it.That said, ideally we would have a safety net in some other layer of the engine. We are patching this call because we know that its current implementation leads to thread-unsafe calls along the call chain. In other words, this fix is a bit flimsy as it relies too much on implementation details of other classes. UPDATE: Implementation changed to move the threading concern to the resource class instead of the translation loader; I'm a bit happier with this, but none should be having to care about that, to be honest.
Fixes #78689 (but testing is needed to confirm; can anyone check?).