Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0] C#: Automatically generate version defines #78811

Merged
merged 1 commit into from
Jun 29, 2023
Merged

[4.0] C#: Automatically generate version defines #78811

merged 1 commit into from
Jun 29, 2023

Conversation

RedworkDE
Copy link
Member

@RedworkDE RedworkDE requested a review from a team as a code owner June 28, 2023 19:51
@RedworkDE RedworkDE mentioned this pull request Jun 28, 2023
Merged
@RedworkDE RedworkDE force-pushed the net-auto-version-defines-4.0 branch from 567f138 to 03ce3f5 Compare June 28, 2023 19:55
@raulsntos raulsntos added this to the 4.0 milestone Jun 28, 2023
@raulsntos raulsntos mentioned this pull request Jun 28, 2023
Merged
raulsntos
raulsntos approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot!

@akien-mga akien-mga merged commit 34b4cce into godotengine:4.0 Jun 29, 2023
@akien-mga
Copy link
Member

Thanks!

@RedworkDE RedworkDE deleted the net-auto-version-defines-4.0 branch June 29, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulsntos raulsntos raulsntos approved these changes

Assignees
No one assigned
Labels
bug enhancement topic:buildsystem topic:dotnet
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@RedworkDE @akien-mga @raulsntos