Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Add platform name to the exported data directory #78846

Merged
merged 1 commit into from
Aug 4, 2023
Merged

C#: Add platform name to the exported data directory #78846

merged 1 commit into from
Aug 4, 2023

Conversation

raulsntos
Copy link
Member

@raulsntos raulsntos added this to the 4.x milestone Jun 29, 2023
@raulsntos raulsntos requested a review from a team as a code owner June 29, 2023 18:10
raulsntos
raulsntos commented Jun 29, 2023
View reviewed changes
modules/mono/godotsharp_dirs.cpp Outdated Show resolved Hide resolved
modules/mono/godotsharp_dirs.cpp Outdated Show resolved Hide resolved
@YuriSizov YuriSizov modified the milestones: 4.x, 4.2 Jul 17, 2023
@raulsntos raulsntos force-pushed the dotnet/data_dir_name_now_with_more_platform branch from 3bd20bb to b9f1136 Compare August 3, 2023 11:13
akien-mga
akien-mga approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Would be good to improve the handling of a missing data dir, e.g. by showing an OS.alert() or at least a clear error message in the terminal, but that can be done in a follow-up.

@raulsntos raulsntos mentioned this pull request Aug 3, 2023
Merged
@YuriSizov YuriSizov merged commit c244903 into godotengine:master Aug 4, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@raulsntos raulsntos deleted the dotnet/data_dir_name_now_with_more_platform branch August 4, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RedworkDE RedworkDE RedworkDE approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:dotnet topic:export
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Linux + C# : "Failed to initialize context for app" on exported project
4 participants
@raulsntos @YuriSizov @akien-mga @RedworkDE