Expose compute_convex_mesh_points function to GDScript
#78871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BastiaanOlij
approved these changes
Aug 9, 2023
BastiaanOlij
reviewed
Aug 9, 2023
core/core_bind.cpp
Outdated
| @@ -919,6 +919,17 @@ Geometry3D *Geometry3D::get_singleton() { | |||
| return singleton; | |||
| } | |||
|
|
|||
| Vector<Vector3> Geometry3D::compute_convex_mesh_points(const TypedArray<Plane> &planes) { | |||
There was a problem hiding this comment.
Little nitpick, naming convention wise, if we have a public function compute_convex_mesh_points that can't be called from GDScript, we call the wrapper function that does any conversions _compute_convex_mesh_points.
There was a problem hiding this comment.
(and this would be a protected method so as to not confuse what to call from C++ even if the method in GDScript does not have the _)
There was a problem hiding this comment.
I was going to rename this, but nothing else in core_bind.cpp follows that naming convention, so that would make this the outlier in this file.
akien-mga
changed the title
compute_convex_mesh_points function to GDScript
jitspoe
force-pushed
the
master.pr_compute_convex_mesh_points
branch
from
8d31a23
to
541b021
Compare
akien-mga
approved these changes
Aug 16, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A useful function that was only available in C++ before. Addresses request: godotengine/godot-proposals#6695