Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDScript: Fix incorrect error message for utility functions #78882

Merged
merged 1 commit into from
Oct 16, 2023
Merged

GDScript: Fix incorrect error message for utility functions #78882

merged 1 commit into from
Oct 16, 2023

Conversation

dalexeev
Copy link
Member

@dalexeev dalexeev commented Jun 30, 2023 •
edited
Loading

  1. The reason for the bug is that Variant::construct() doesn't return the error text.
  2. Also this PR fixes <unknown function> for GDScript utility functions.
convert({1: 2, 3: 4}, TYPE_STRING)

Before:

Invalid call. Nonexistent GDScript utility function '<unknown function>'.

After:

Error calling GDScript utility function "convert()": Cannot convert "Dictionary" to "String".

@dalexeev dalexeev requested a review from a team as a code owner June 30, 2023 17:46
@akien-mga akien-mga added this to the 4.2 milestone Jun 30, 2023
@dalexeev dalexeev force-pushed the gds-fix-utility-func-err-msg branch from d5fb2b3 to 42996b4 Compare October 16, 2023 08:11
@dalexeev dalexeev requested review from a team as code owners October 16, 2023 08:11
@AThousandShips AThousandShips mentioned this pull request Oct 16, 2023
Closed
@dalexeev dalexeev force-pushed the gds-fix-utility-func-err-msg branch 3 times, most recently from 16b3513 to a7dc273 Compare October 16, 2023 10:45
@dalexeev dalexeev force-pushed the gds-fix-utility-func-err-msg branch from a7dc273 to 0c2202c Compare October 16, 2023 11:10
@akien-mga akien-mga merged commit 50212ec into godotengine:master Oct 16, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@dalexeev dalexeev deleted the gds-fix-utility-func-err-msg branch October 16, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vnen vnen vnen approved these changes

Assignees
No one assigned
Labels
bug topic:core topic:gdscript
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

GDScript 2.0: Unknown Function convert() in @GDScript scope
3 participants
@dalexeev @akien-mga @vnen