Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect property names in FontFile::_get_property_list() #78907

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

zorbathut
Copy link
Contributor

These property names provided in _get_property_list() are mis-tagged; the prefix was missed for each except variation_coordinates. Compare to the FontFile::_get() and ::_set() located immediately above.

@zorbathut zorbathut requested a review from a team as a code owner July 1, 2023 13:50
@akien-mga akien-mga changed the title Fix: Incorrect property names in FontFile::_get_property_list(). Fix: Incorrect property names in FontFile::_get_property_list() Jul 1, 2023
@akien-mga akien-mga changed the title Fix: Incorrect property names in FontFile::_get_property_list() Fix incorrect property names in FontFile::_get_property_list() Jul 1, 2023
@akien-mga akien-mga added this to the 4.2 milestone Jul 1, 2023
@akien-mga akien-mga added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jul 1, 2023
@akien-mga akien-mga merged commit 963cf54 into godotengine:master Jul 7, 2023
@akien-mga
Copy link
Member

Thanks!

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jul 10, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants