-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RTL] Add pop_all
, push_context
and pop_context
methods, and use it for print_rich
to avoid unclosed tags.
#79011
Conversation
Are there any benefits to doing this other than less code? Just curious if I should still do things the old way unless necessary. |
|
I believe in our built-in documentation we have plenty of cases where we need to pop N levels from the stack, but not all of it. Would something like a scope or a context make sense as well?
|
…e it for `print_rich` to avoid unclosed tags.
pop_all
method, and use it for print_rich
to avoid unclosed tags.pop_all
, push_context
and pop_context
methods, and use it for print_rich
to avoid unclosed tags.
Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovin' it!
Thanks! Now someone could do a pass simplifying calls in the built-in help :) |
Code simplification with new methods? I'm in. |
Fixes #78520