Move cached values into color_mode.cpp and apply fixes to OKHSL
#79037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinoplane
force-pushed
the
move-cached-values
branch
2 times, most recently
from
5555a2f to
ff80fd3
Compare
KoBeWi
reviewed
Jul 4, 2023
dinoplane
force-pushed
the
move-cached-values
branch
from
ff80fd3 to
c7dbd59
Compare
KoBeWi
reviewed
Jul 5, 2023
KoBeWi
reviewed
Jul 5, 2023
dinoplane
force-pushed
the
move-cached-values
branch
from
c7dbd59 to
35ef6b1
Compare
KoBeWi
reviewed
Jul 5, 2023
dinoplane
force-pushed
the
move-cached-values
branch
from
35ef6b1 to
3f02b0c
Compare
KoBeWi
approved these changes
Jul 5, 2023
YuriSizov
changed the title
color_mode.cpp (and applied fixes to OKHSL)color_mode.cpp and apply fixes to OKHSL
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm following up a quote by @KoBeWi on #78486 and #77863. I have moved the caching logic into the color_mode.
#78486 (comment)
However, I am debating whether to move out the
h,s,v, andlast_colorvalues as well. Forh,s, andv, I see that they are used by other functions such as_w_inputand_uv_input. It seems these are part of the picker shape.. Forlast_color, I believe this is a part of the last_color shown in the picker. Thus, I did not move this logic into color_mode.In addition, I applied the same logic to OKHSL, it seems I overlooked the issue a while back. This logic is put in
color_mode.cpp