-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux: Link libsquish directly when unbundling, .pc file unreliable #79105
Linux: Link libsquish directly when unbundling, .pc file unreliable #79105
Conversation
That's weird. From what I can see, Arch Linux has it and it looks like they don't copy it manually, although they use a newer version. https://archlinux.org/packages/extra/x86_64/libsquish/files/ Edit: posted too early. I wanted to add: Is there a reason that you're both using 1.14 instead of 1.15? |
You must have misread, both Fedora and Mageia use 1.15. libsquish hasn't had a new release since 2017. Not sure how the Arch package gets the .pc file installed properly, I'll experiment. Still, it's probably not just Fedora lacking the file and until all distros have it properly packaged, we should probably not assume that it's there. |
No problem under Debian either https://packages.debian.org/bookworm/libsquish-dev |
The Arch package does some pretty weird stuff, building first with CMake, but then installing the CMake things manually and running the squish original Makefile (which does install the .pc file), instead of using the upstream CMake. Debian only uses the Makefile and doesn't use their CMake at all. Fedora and Mageia fixed up the CMake but did not add the pkgconfig handling code so it needs to be installed manually. All distros have to patch the .pc file anyway because it's broken by default... It's a mess :) |
@akien-mga yup, I shomehow misread. Oops. Thanks for investigating! Yeah, the situation looks very messy. I agree that it makes sense to directly link at this point. |
Cherry-picked for 4.1.1. |
For the record, I have the pkgconfig file installed on Mageia, but I had to fix it and install it manually:
http://svnweb.mageia.org/packages/cauldron/libsquish/current/SPECS/libsquish.spec?view=markup
Fedora doesn't do that so they don't have it: https://src.fedoraproject.org/rpms/libsquish/blob/rawhide/f/libsquish.spec