Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Variant icons and a few others #79161

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Optimize Variant icons and a few others #79161

merged 1 commit into from
Sep 14, 2023

Conversation

MewPurPur
Copy link
Contributor

@MewPurPur MewPurPur commented Jul 7, 2023 •
edited
Loading

Tweaks variant icons a bit for readability and optimizes them for a 6 kB save.

edit: Later I hijacked the PR to optimize a dozen more icons.

@MewPurPur MewPurPur requested a review from a team as a code owner July 7, 2023 15:00
@AThousandShips AThousandShips added this to the 4.x milestone Jul 7, 2023
@MewPurPur MewPurPur force-pushed the variant-icons branch 2 times, most recently from c674edb to 6dcf808 Compare July 18, 2023 12:28
@MewPurPur MewPurPur changed the title Optimize Variant icons Optimize Variant icons and a few others Sep 12, 2023
Calinou
Calinou approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Binary size of stripped Linux x86_64 debug editor build:

  • Before: 152,122,672 bytes
  • After (this PR): 152,117,008 bytes (-5.6 KB)

I looked at icons within the editor and they look correct.

@YuriSizov YuriSizov modified the milestones: 4.x, 4.2 Sep 14, 2023
@YuriSizov YuriSizov merged commit aa075e2 into godotengine:master Sep 14, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@MewPurPur MewPurPur deleted the variant-icons branch September 14, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@MewPurPur @YuriSizov @Calinou @AThousandShips