Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextServer] Remove excessive Dictionary checks. #79166

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jul 7, 2023

Remove dictionary equality check to allow reusing variation dictionary without make a copy:

Allows code like this:

var coords = font.variation_opentype # currently works only with .duplicate()
coords["weight"] = 1000
font.variation_opentype = coords

I'm not sure if there's a way to track dictionary element change to do it like:

font.variation_opentype["weight"] = 1000 # won't work

@bruvzg bruvzg marked this pull request as ready for review September 4, 2023 07:20
@bruvzg bruvzg requested a review from a team as a code owner September 4, 2023 07:20
@YuriSizov YuriSizov merged commit c9bf824 into godotengine:master Sep 5, 2023
@YuriSizov
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants