Show only compatible nodes in 'Select a node' window

[martinboue]

Resolve proposal godotengine/godot-proposals#7217

Result:

• Bugsquad edit, closes: Show only compatible nodes in "Select a node" window godot-proposals#7217

[MewPurPur]

I'd suggest changing the text to just "Show All" as there's nothing else it could be, and to cuddle it up on the same horizontal level as the filter input field. You're very unlikely to write something really long in it. Also, both serve the same purpose of filtering.

^ Example of a similar thing elsewhere in the editor.

[martinboue]

Indeed, looks much better now @MewPurPur 😊

[MewPurPur]

LGTM. Nitpick - Our code style enforces punctuation for proper sentences.

[martinboue]

LGTM. Nitpick - Our code style enforces punctuation for proper sentences.

Oh, didn't know about that @MewPurPur , that's no problem. Should be fixed.

(Now that you've said it, I notice these dots everywhere! 😄)

[MewPurPur]

Lots of places in the codebase are missing dots, yeah. You can often date Godot's code by how its comments look :P

[martinboue]

Is there anything left I need to do before merge ?

[MewPurPur]

It's a waiting game now!

[martinboue]

Update

Rebased with master and tested with #79593 / #79593 and works fine:

Also moved the code to create the 'Show All' CheckButton inside the newly SceneTreeDialog::set_valid_types method.

[MewPurPur]

There's an erroneous tab making static checks fail. We keep empty lines really empty for consistency in code style.

[Calinou]

Tested locally (rebased on top of master c495eb5), it works as expected.

Testing project: test_pr_79213.zip

Node tree

Without filter

Show All disabled	Show All enabled

With filter

Show All disabled	Show All enabled

[martinboue]

@Calinou I don't think it's working properly when 'Show All' is disabled. On your screenshots, the nodes in red should not appear:

I'll fix it, thanks for testing!

[martinboue]

It's fixed, here is the updated result with the test project provided by @Calinou :

Without filter

Show All disabled	Show All enabled

With filter

Show All disabled	Show All enabled

[akien-mga]

Minor nitpick, but usually we keep the title of commit messages only for the description of the change, and references to issues / proposals go in the body of the commit, e.g.:

Show only compatible nodes in 'Select a node' window

Fixes https://github.com/godotengine/godot-proposals/issues/7217

[KoBeWi]

I think the state of Show All should be remembered between sessions. You can use EditorSettings.set_project_metadata() for that.

[martinboue]

Minor nitpick, but usually we keep the title of commit messages only for the description of the change, and references to issues / proposals go in the body of the commit, e.g.:

Show only compatible nodes in 'Select a node' window

Fixes https://github.com/godotengine/godot-proposals/issues/7217

Noted, it's updated. Thanks.

I think the state of Show All should be remembered between sessions. You can use EditorSettings.set_project_metadata() for that.

It's done. I've used "editor_metadata" as section, which I thought was the most suitable. I'm not sure if that's the correct one, please correct me if necessary, I don't know how the metadata are organised.

EditorSettings::get_singleton()->get_project_metadata("editor_metadata", "show_all_nodes", false)

[KoBeWi]

"editor_metadata" section is fine, but the name is not very descriptive. Something like "show_all_nodes_for_node_selection" would be better.

[KoBeWi]

Left some minor comments, but otherwise it's fine.

[martinboue]

Everything is fixed, should be ready to merge. Thanks everyone for testing and reviewing ❤️

[akien-mga]

Thanks!