-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep GraphNode
port icons crisp at high zoom levels and remove artifacts
#79262
Keep GraphNode
port icons crisp at high zoom levels and remove artifacts
#79262
Conversation
2fd3c74
to
4e04eb1
Compare
TIL about PS: The class reference description for |
Same as you, I just learned about that method today and wished I had sooner. (I stumbled upon it accidentally while looking for a way to implement this exact functionality) |
4e04eb1
to
1bea64a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's an interesting trick. I wonder if we can utilize it elsewhere.
GraphNode
port icons crisp at high zoom levels and remove artifacts
Thanks! |
With zoom levels up to 207%, the port icons are noticeably stretched. You can also observe interpolation/sampling artifacts because the circle touches all edges of the SVG's viewport. This can be solved with size overrides and adjusting the circle/the image's dimensions.
Before/After: