Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify error condition for particles trail lifetime #79270

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

clayjohn
Copy link
Member

Fixes: #79091

The error condition was 0.01 in the high-level nodes, 0.1, in the server, but the property only allows setting it as small as 0.01 with a granularity of 0.01. Accordingly, unify all places to use 0.01. I tested locally and while a value of 0.01 results in a very tiny trail, it still works fine.

This inconsistency appears to date back to when trails were first implemented 9005646

Property bindings for reference:

ADD_PROPERTY(PropertyInfo(Variant::FLOAT, "trail_lifetime", PROPERTY_HINT_RANGE, "0.01,10,0.01,or_greater,suffix:s"), "set_trail_lifetime", "get_trail_lifetime");

ADD_PROPERTY(PropertyInfo(Variant::FLOAT, "trail_lifetime", PROPERTY_HINT_RANGE, "0.01,10,0.01,or_greater,suffix:s"), "set_trail_lifetime", "get_trail_lifetime");

@clayjohn clayjohn added bug topic:particles cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Jul 10, 2023
@clayjohn clayjohn added this to the 4.2 milestone Jul 10, 2023
@clayjohn clayjohn requested review from a team as code owners July 10, 2023 08:24
@akien-mga akien-mga merged commit 7030ac5 into godotengine:master Jul 10, 2023
@akien-mga
Copy link
Member

Thanks!

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jul 10, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting trail_lifetime of a particle below 0.1 will always result in an ERROR_COND
3 participants