Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify return value of get_dependencies() #79306

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Clarify return value of get_dependencies() #79306

merged 1 commit into from
Jul 12, 2023

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jul 10, 2023

Closes #79300

@KoBeWi KoBeWi added enhancement topic:core documentation cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Jul 10, 2023
@KoBeWi KoBeWi added this to the 4.2 milestone Jul 10, 2023
@KoBeWi KoBeWi requested a review from a team as a code owner July 10, 2023 21:25
@akien-mga
Copy link
Member

Could you also add a mention to this in the "Changed" section of the 4.0 changelog in CHANGELOG.md? Linking the PR which changed this method.

@KoBeWi
Copy link
Member Author

KoBeWi commented Jul 10, 2023 •
edited
Loading

How it should be described? The PR title only mentions the fixed issue.
EDIT: Done.

akien-mga
akien-mga reviewed Jul 11, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@YuriSizov YuriSizov merged commit aa353df into godotengine:master Jul 12, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@KoBeWi KoBeWi deleted the broken_as_intended branch July 12, 2023 11:04
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.1.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

ResourceLoader::get_dependencies breaking change in 4.1
3 participants
@KoBeWi @akien-mga @YuriSizov