Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test suite for TranslationServer #79331

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Add a test suite for TranslationServer #79331

merged 1 commit into from
Aug 7, 2023

Conversation

azuloo
Copy link
Contributor

@azuloo azuloo commented Jul 11, 2023

A test suite that covers TranslationServer, #43440 for more details.

@azuloo azuloo requested a review from a team as a code owner July 11, 2023 11:09
@AThousandShips AThousandShips added this to the 4.x milestone Jul 11, 2023
@AThousandShips
Copy link
Member

Please squash your commits, and make changes like this with git commit --amend in the future

@azuloo azuloo force-pushed the translation-server-test-suite branch from f820240 to dd0bd90 Compare July 11, 2023 11:33
@Calinou Calinou mentioned this pull request Jul 13, 2023
Closed
Sauermann
Sauermann approved these changes Aug 6, 2023
View reviewed changes
Copy link
Contributor

@Sauermann Sauermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't look into every check, but PR is looking good to me.

@akien-mga akien-mga modified the milestones: 4.x, 4.2 Aug 7, 2023
@akien-mga akien-mga merged commit 66e40e4 into godotengine:master Aug 7, 2023
13 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@azuloo azuloo deleted the translation-server-test-suite branch August 7, 2023 13:17
@azuloo azuloo mentioned this pull request Sep 22, 2023
Open
99 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sauermann Sauermann Sauermann approved these changes

Assignees
No one assigned
Labels
enhancement topic:core topic:tests
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@azuloo @AThousandShips @akien-mga @Sauermann