Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Improve signal callback generation #79366

Merged
merged 1 commit into from
Sep 17, 2023
Merged

Editor: Improve signal callback generation #79366

merged 1 commit into from
Sep 17, 2023

Conversation

dalexeev
Copy link
Member

@dalexeev dalexeev commented Jul 12, 2023 •
edited
Loading

Note: Some changes have been extracted to #80745, #80765 and #81079.

Added support for typed arrays, enums and Variant.

@dalexeev dalexeev added this to the 4.2 milestone Jul 12, 2023
@dalexeev dalexeev force-pushed the gds-signal-info-and-callback branch 4 times, most recently from 7798c03 to ba98907 Compare July 18, 2023 11:05
@dalexeev dalexeev mentioned this pull request Jul 18, 2023
Closed
@dalexeev dalexeev marked this pull request as ready for review July 18, 2023 11:49
@dalexeev dalexeev requested review from a team as code owners July 18, 2023 11:49
@dalexeev dalexeev force-pushed the gds-signal-info-and-callback branch from ba98907 to bbd5606 Compare July 18, 2023 12:15
@dalexeev dalexeev mentioned this pull request Jul 24, 2023
Open
@dalexeev

This comment was marked as outdated.

Sign in to view
@dalexeev dalexeev force-pushed the gds-signal-info-and-callback branch from bbd5606 to b6e9be1 Compare August 18, 2023 04:36
@dalexeev dalexeev mentioned this pull request Aug 18, 2023
Merged
@dalexeev dalexeev force-pushed the gds-signal-info-and-callback branch from b6e9be1 to 129f404 Compare August 18, 2023 06:34
@dalexeev dalexeev mentioned this pull request Aug 18, 2023
Open
@dalexeev dalexeev mentioned this pull request Aug 31, 2023
Merged
@dalexeev dalexeev marked this pull request as draft September 1, 2023 13:36
@dalexeev dalexeev changed the title GDScript: Add type info to get_script_signal_list() Editor: Improve signal callback generation Sep 3, 2023
@dalexeev dalexeev marked this pull request as ready for review September 11, 2023 15:52
raulsntos
raulsntos approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The C# changes look good to me. Should likely be reviewed by the Editor team as well.

@akien-mga akien-mga requested a review from a team September 14, 2023 12:44
YuriSizov
YuriSizov approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an improvement, and a bugfix too. There are probably still cases which aren't handled perfectly, but they are certainly not handled worse than before.

@akien-mga akien-mga merged commit c63e0ae into godotengine:master Sep 17, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@dalexeev dalexeev deleted the gds-signal-info-and-callback branch September 17, 2023 12:51
@raulsntos raulsntos mentioned this pull request Oct 7, 2023
Closed
@dalexeev dalexeev mentioned this pull request Feb 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulsntos raulsntos raulsntos approved these changes

@YuriSizov YuriSizov YuriSizov approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@dalexeev @akien-mga @raulsntos @YuriSizov