Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add autocomplete for filter/repeat hints on uniform arrays #79402

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Add autocomplete for filter/repeat hints on uniform arrays #79402

merged 1 commit into from
Jul 17, 2023

Conversation

Haydoggo
Copy link
Contributor

Adds autocomplete support for the hints added in #79100

@Haydoggo Haydoggo requested a review from a team as a code owner July 12, 2023 23:30
@Calinou Calinou added this to the 4.2 milestone Jul 13, 2023
@Calinou Calinou added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jul 13, 2023
RandomShaper
RandomShaper approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@RandomShaper RandomShaper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. TIWAGOS, IAC*.

*: In any case.

@clayjohn clayjohn merged commit f880892 into godotengine:master Jul 17, 2023
13 checks passed
@clayjohn
Copy link
Member

Note for cherrypicking, this should not be cherrypicked before #79100

@clayjohn
Copy link
Member

Thanks for the contribution!

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.2.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Aug 31, 2023
@Haydoggo Haydoggo deleted the repeat-filter-autocomplete branch February 17, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomShaper RandomShaper RandomShaper approved these changes

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor topic:shaders
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
5 participants
@Haydoggo @clayjohn @YuriSizov @RandomShaper @Calinou