Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Web] Fix WebSocket returning empty close-reason. #79407

Merged
merged 1 commit into from
Oct 13, 2023
Merged

[Web] Fix WebSocket returning empty close-reason. #79407

merged 1 commit into from
Oct 13, 2023

Conversation

zaevi
Copy link
Contributor

@zaevi zaevi commented Jul 13, 2023

Fix #79365.

Removes duplicate string-parsing of reason.

@zaevi zaevi requested a review from a team as a code owner July 13, 2023 05:15
@Sauermann Sauermann added this to the 4.2 milestone Jul 14, 2023
Faless
Faless approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@Faless Faless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 .
Thanks!

@AThousandShips AThousandShips changed the title [Web]Fix WebSocket returning empty close-reason. [Web] Fix WebSocket returning empty close-reason. Oct 12, 2023
@akien-mga akien-mga merged commit 5e9d096 into godotengine:master Oct 13, 2023
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Faless Faless Faless approved these changes

Assignees
No one assigned
Labels
bug platform:web topic:network topic:porting
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

[Web] WebSocketPeer.get_close_reason() always returns empty string.
4 participants
@zaevi @akien-mga @Faless @Sauermann