Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rendering driver in Copy System Info for the Compatibility rendering method #79416

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Fix rendering driver in Copy System Info for the Compatibility rendering method #79416

merged 1 commit into from
Jul 18, 2023

Conversation

sepTN
Copy link
Contributor

@sepTN sepTN commented Jul 13, 2023

Fix #79391

@AThousandShips AThousandShips added this to the 4.2 milestone Jul 13, 2023
@AThousandShips AThousandShips changed the title Fix Copy System Info to copy the correct rendering driver for the Compatibility rendering method Fix rendering driver in Copy System Info for the Compatibility rendering method Jul 13, 2023
@sepTN sepTN force-pushed the fix-copy-system-info branch from df9976b to 4758ef9 Compare July 13, 2023 10:07
@YuriSizov YuriSizov requested a review from Calinou July 13, 2023 14:36
@clayjohn
Copy link
Member

I don't think this is the right fix. Reading the code above, it looks like driver_name is always set to GLOBAL_GET("rendering/rendering_device/driver"). However, when using the GL_Compatibility backend, the driver name should come from GLOBAL_GET("rendering/gl_compatibility/driver").

Right now force setting the driver name works becuase there is only one driver for the GL Compatibility backend, but soon we will have 2 backends on many platforms, so we should fix this properly

@sepTN sepTN force-pushed the fix-copy-system-info branch from 40f6ad0 to c4b878c Compare July 17, 2023 23:17
@YuriSizov YuriSizov requested a review from clayjohn July 18, 2023 00:14
clayjohn
clayjohn approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@YuriSizov YuriSizov merged commit 79a9e79 into godotengine:master Jul 18, 2023
@YuriSizov
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@clayjohn clayjohn clayjohn approved these changes

@Calinou Calinou Awaiting requested review from Calinou

Assignees
No one assigned
Labels
bug topic:editor
Projects
None yet
Milestone
4.2
4 participants
@sepTN @clayjohn @YuriSizov @AThousandShips