Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using floating-point bone sizes and outline widths in the 2D editor #79434

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Allow using floating-point bone sizes and outline widths in the 2D editor #79434

merged 1 commit into from
Jul 24, 2023

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jul 13, 2023 •
edited
Loading

This is useful when animating pixel art sprites in the 2D editor, as a value of 1 is often too large when zoomed in.

I've tested this change locally and can confirm that sizes as low as 0.01 work without any errors (and with visible output, at high zoom levels).

@Calinou Calinou requested review from a team as code owners July 13, 2023 18:05
@Calinou Calinou added enhancement topic:editor topic:2d usability cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Jul 13, 2023
@Calinou Calinou added this to the 4.2 milestone Jul 13, 2023
@Calinou Calinou force-pushed the 2d-editor-allow-float-bone-size branch from 3885993 to ceb3c6a Compare July 15, 2023 23:40
@Calinou
Allow using floating-point bone sizes and outline widths in the 2D ed…
a39190a 
…itor

This is useful when animating pixel art sprites in the 2D editor,
as a value of `1` is often too large when zoomed in.
@Calinou Calinou force-pushed the 2d-editor-allow-float-bone-size branch from ceb3c6a to a39190a Compare July 17, 2023 10:44
clayjohn
clayjohn approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me

@YuriSizov YuriSizov merged commit 2f4c962 into godotengine:master Jul 24, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.3.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 19, 2023
@Calinou Calinou deleted the 2d-editor-allow-float-bone-size branch October 19, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor topic:2d usability
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Allow 'Bone Width' to be a decimal value and/or add 'Bone Style' option
3 participants
@Calinou @YuriSizov @clayjohn