Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for PackedScene #79440

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Add unit tests for PackedScene #79440

merged 1 commit into from
Aug 7, 2023

Conversation

sepTN
Copy link
Contributor

@sepTN sepTN commented Jul 13, 2023

Adding test suite that covers PackedScene. I never wrote unit tests before so this is my first attempt 😄, feedback is appreciated.

Link back to #43440

@sepTN sepTN requested a review from a team as a code owner July 13, 2023 21:00
@sepTN sepTN force-pushed the test-packed-scene branch from c389131 to acffc54 Compare July 13, 2023 21:04
@Calinou Calinou added this to the 4.2 milestone Jul 13, 2023
Sauermann
Sauermann approved these changes Aug 6, 2023
View reviewed changes
Copy link
Contributor

@Sauermann Sauermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good to me

@sepTN sepTN force-pushed the test-packed-scene branch from 9b79e46 to cd94f9a Compare August 6, 2023 16:52
@akien-mga akien-mga merged commit 3532661 into godotengine:master Aug 7, 2023
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou mentioned this pull request Feb 21, 2024
Open
99 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sauermann Sauermann Sauermann approved these changes

Assignees
No one assigned
Labels
enhancement topic:tests
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@sepTN @akien-mga @Sauermann @Calinou