Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 2D navigation ProjectSettings from integers to floats #79483

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

smix8
Copy link
Contributor

@smix8 smix8 commented Jul 14, 2023

Changes 2D navigation ProjectSettings from integers to floats.

Related issue #79474.

That was some arbitrary limitation added just for the ProjectSettings considering that those properties are floats everywhere else.

@smix8 smix8 added bug topic:navigation topic:2d cherrypick:4.0 cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Jul 14, 2023
@smix8 smix8 requested a review from a team as a code owner July 14, 2023 20:05
@smix8 smix8 added this to the 4.2 milestone Jul 14, 2023
Copy link

@mohe2015 mohe2015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the type and default in doc/classes/ProjectSettings.xml be somehow synced with this update or is this missing in this PR?

Changes 2D navigation ProjectSettings from integers to floats.
@smix8 smix8 requested a review from a team as a code owner July 14, 2023 20:36
@smix8
Copy link
Contributor Author

smix8 commented Jul 14, 2023

Will the type and default in doc/classes/ProjectSettings.xml be somehow synced with this update or is this missing in this PR?

Forgot to build the ProjectSettings xml.

Will only work for new projects or projects that have not changed the defaults. If an existing project has already changed the ProjectSettings the value will need to be reset first.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jul 18, 2023
@YuriSizov
Copy link
Contributor

Will only work for new projects or projects that have not changed the defaults. If an existing project has already changed the ProjectSettings the value will need to be reset first.

This doesn't make it a good candidate for cherry-picking then.

@YuriSizov YuriSizov merged commit d704888 into godotengine:master Jul 18, 2023
13 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@smix8 smix8 deleted the nav2d_pj_props_4.x branch July 18, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants