Prevent GDExtensions from trying to remove editor plugins at shutdown #79492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it would be a mistake from extension devs trying to remove plugins when they shouldnt, would it possible to log an error to indicate that something is wrong? |
|
It's not necessarily a mistake from devs. If a GDExtension is getting unloaded at shutdown, the extension shouldn't remove it's editor plugins (it should be a no-op), but if it's getting unloaded at any other time (even though you'd never do that currently because it'd break in other ways :-)) then it should remove them. But the dev really has no way to tell the difference. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes godotengine/godot-cpp#1178