Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#: Suppress NU5128 warning #79501

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

raulsntos
Copy link
Member

Suppress dependencies of SourceGenerators package to fix NU5128.

For more context see #65532 (comment). As per the NU5128 documentation:

If your package does not contain any lib/ or ref/ files and is not a meta-package, it likely does not have any dependencies that the package consumer needs. If you are packing with NuGet's MSBuild Pack target, you can set <SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking> in any PropertyGroup in your project file. If you are using a custom nuspec file, remove the <dependencies> element.

This seems to be a well-known false positive in analyzer projects:

Suppress dependencies of SourceGenerators package to fix NU5128.
@raulsntos raulsntos added this to the 4.x milestone Jul 15, 2023
@raulsntos raulsntos requested a review from neikeq July 15, 2023 13:51
@raulsntos raulsntos requested a review from a team as a code owner July 15, 2023 13:51
@raulsntos raulsntos mentioned this pull request Jul 15, 2023
3 tasks
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rationale makes sense to me.

@akien-mga akien-mga modified the milestones: 4.x, 4.2 Aug 2, 2023
@YuriSizov YuriSizov merged commit 0a9006a into godotengine:master Aug 2, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@raulsntos raulsntos deleted the dotnet/warnings/NU5128 branch August 2, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants