Change GDScript tests to use InstancePlaceholder as the example abstract class #79524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! For the record, the canvas item changes should've been avoided here, since they aren't relevant to the improvements. But it wasn't worth the trouble to request an amendment :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is split off from #67510 for easy reviewing.
It changes the GDScript tests to use InstancePlaceholder as the example abstract class instead of CanvasItem, since I want to allow extending CanvasItem. Why InstancePlaceholder: somewhat arbitrary, out of the current abstract classes this seems like a class that nobody would ever want to extend.
Also, this PR includes some formatting fixes in
canvas_item.h.