Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate input-handled-state for different events during physics-picking #79546

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Separate input-handled-state for different events during physics-picking #79546

merged 1 commit into from
Jul 21, 2023

Conversation

Sauermann
Copy link
Contributor

@Sauermann Sauermann commented Jul 16, 2023 •
edited
Loading

Currently the input-handled-state for different events during physics-picking can interfere with each other, which means, that is_input_handled works only for Control-nodes.
This PR makes sure, that the input_handled_state is reset before processing an InputEvent during physics-picking, so that is_input_handled can additionally be used for Node2D/Node3D physics-picking.

While #76439 is not fixed, this PR will not work, when physics-picking happens in a SubViewportContainer.

resolve #79539

@Sauermann
Separate input-handled-state for different events during physics-picking
95d294b 
Currently the input-handled-state for different events can interfere with
each other.
This PR makes sure, that the input_handled_state is reset before
processing and InputEvent during physics-picking.
@Sauermann Sauermann added this to the 4.2 milestone Jul 16, 2023
@Sauermann Sauermann requested a review from a team as a code owner July 16, 2023 12:45
RandomShaper
RandomShaper approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@RandomShaper RandomShaper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always, changes in this areas are hard to assess, but looks good enough and we're early in the release cycle for 4.2, so I'd give it a try.

@YuriSizov YuriSizov merged commit 15c0e40 into godotengine:master Jul 21, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@Sauermann Sauermann deleted the fix-input-handled-physics branch July 22, 2023 16:00
@Sauermann Sauermann mentioned this pull request Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomShaper RandomShaper RandomShaper approved these changes

Assignees
No one assigned
Labels
enhancement topic:input
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

is_input_handled() is True by default even though set_input_as_handled() has not been called
3 participants
@Sauermann @YuriSizov @RandomShaper