Change to new PICO interaction profiles #79570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BastiaanOlij
force-pushed
the
new_pico_interactions
branch
from
b8e71b7 to
e992d31
Compare
BastiaanOlij
force-pushed
the
new_pico_interactions
branch
from
e992d31 to
26e775b
Compare
|
Just ran through testing this on my PICO now that some unrelated build issues have been resolved. This looks to work properly for me. |
akien-mga
approved these changes
Aug 27, 2023
BastiaanOlij
force-pushed
the
new_pico_interactions
branch
from
26e775b to
fba52b6
Compare
|
Thanks @AThousandShips ! |
|
Needs rebase after Edit: Also while rebasing, remember that the newly bound method will also need documentation. |
BastiaanOlij
force-pushed
the
new_pico_interactions
branch
2 times, most recently
from
a90a8c9 to
e6c6009
Compare
BastiaanOlij
force-pushed
the
new_pico_interactions
branch
from
e6c6009 to
3a89bb3
Compare
|
@akien-mga all done :) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added the Pico interaction we're using before they had officially passed the OpenXR conformance test. The profiles were changed and separate profiles introduced for the neo3 and Pico 4.
While Pico has kept the unofficial interaction profile for backwards compatibility, the correct profiles should be used.
Users with existing applications may need to update their action maps, though I've added a rename for the main profile.
Fixes: #79019