Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix script name of Hant and Hans #79654

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Conversation

timothyqiu
Copy link
Member

@timothyqiu timothyqiu commented Jul 19, 2023

A script named "Traditional" or "Simplified" makes no sense :P

This PR changes the names to "Han (Traditional variant)" and "Han (Simplified variant)".

Note: This makes get_locale_name() return Chinese (Han (Simplified variant)) for zh-Hans. But script name with parentheses already exists for Mymr.

p.s. The generalized CJK hani was correctly named "Han".

@timothyqiu timothyqiu requested a review from a team as a code owner July 19, 2023 10:18
@timothyqiu timothyqiu requested review from bruvzg and removed request for a team July 19, 2023 10:18
@AThousandShips
Copy link
Member

AThousandShips commented Jul 19, 2023

The formal ISO 15924 names are "Han (Simplified/Traditional variant)", could be good to go with that for standard

Hani in turn is named "Han (Hanzi, Kanji, Hanja)"

The list even cites this standard as reference

@timothyqiu
Copy link
Member Author

Yeah, that could be an option. My concern is that the name is used by get_locale_name(). The generated locale name is Language (Script), Country. So using parentheses would produce Chinese (Han (Simplified variant)) for zh-Hans.

@AThousandShips
Copy link
Member

AThousandShips commented Jul 19, 2023

That still happens for some entries though, like Mymr

Otherwise just "Han, Simplified/Traditional variant"

@@ -1057,8 +1057,8 @@ static const char *script_list[][2] = {
{ "Hangul", "Hang" },
{ "Han", "Hani" },
{ "Hanunoo", "Hano" },
{ "Simplified", "Hans" },
{ "Traditional", "Hant" },
{ "Han (Simplified variant)", "Hans" },
Copy link
Member

@adamscott adamscott Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this have the same issue that you said about double parentheses?

Copy link
Member Author

@timothyqiu timothyqiu Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we already have such names and this is a standard name, I think it might be acceptable.

But yeah, I still think "Simplified/Traditional Han" would look better.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only other case is Myanmar (Burmese), maybe it's better to change it to Myanmar / Burmese as well and use Simplified Han + Traditional Han to avoid extra parentheses.

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@YuriSizov YuriSizov merged commit 8654ba1 into godotengine:master Aug 1, 2023
13 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@timothyqiu timothyqiu deleted the han branch August 1, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants