Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholder items to TileSet layer list #79676

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jul 19, 2023

Adds a fake item + tooltip telling how to setup layers:
image

Before:
image

@groud
Copy link
Member

groud commented Jul 20, 2023

Thanks! I think the solution is ok-ish, but I feel those items are maybe grabbing attention too much. Would it be possible to tone them down a bit ? Like setting them as "disabled" or something like that ?

@KoBeWi
Copy link
Member Author

KoBeWi commented Jul 20, 2023

image

@groud
Copy link
Member

groud commented Jul 20, 2023

image

Nice! Maybe we should do the same for the Icon too (I don't know if we have a modulation option for the icon ?) . That would be perfect IMO.

Co-authored-by: MewPurPur <mew.pur.pur@abv.bg>
@KoBeWi
Copy link
Member Author

KoBeWi commented Jul 20, 2023

image

Copy link
Member

@groud groud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Looks perfect to me!

@YuriSizov YuriSizov merged commit dbff173 into godotengine:master Jul 24, 2023
13 checks passed
@KoBeWi KoBeWi deleted the MissingNo.Layers branch July 24, 2023 17:42
@YuriSizov
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants