Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Initialize COM as apartment-threaded. #79693

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jul 20, 2023

Fixes unresponsive window when showing native file dialogs - #79574 (comment)
Fixes #79496

It should not reintroduce #74288, #73039, #74396, and #71835, but it's hard to reproduce any of these, so testing is appreciated, cc @Ranoller.

@bruvzg bruvzg added this to the 4.2 milestone Jul 20, 2023
@bruvzg bruvzg requested review from a team as code owners July 20, 2023 09:21
@akien-mga akien-mga added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Aug 7, 2023
@akien-mga akien-mga merged commit 048a164 into godotengine:master Aug 7, 2023
@akien-mga
Copy link
Member

Thanks!

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 19, 2023
@YuriSizov
Copy link
Contributor

This addresses a problem reported on a 4.2 feature and changes in this PR depend on it. If there is a reason to have this in 4.1.x, then a dedicated PR is needed.

@bruvzg
Copy link
Member Author

bruvzg commented Oct 19, 2023

This addresses a problem reported on a 4.2 feature and changes in this PR depend on it. If there is a reason to have this in 4.1.x, then a dedicated PR is needed.

Yes, it should fix issues with some IME modules (#79496) in addition to file dialogs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to input Chinese using palm input method
3 participants