Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use existing plugin.cfg in configuration dialog #79723

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jul 20, 2023

@IceflowRE
Copy link
Contributor

As already stated in the issue, wouldn't it be better to avoid loading the file twice?

@KoBeWi
Copy link
Member Author

KoBeWi commented Jul 20, 2023

It doesn't matter. It's still better than project metadata, which is loaded with every access 🙃

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Would rebase for good measure.

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Apr 26, 2024
@KoBeWi KoBeWi force-pushed the tfw_you_single-linedly_implement_a_proposal branch from 15c4602 to 7b3da23 Compare April 26, 2024 12:38
@akien-mga akien-mga merged commit 593e308 into godotengine:master Apr 26, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the tfw_you_single-linedly_implement_a_proposal😎 branch April 26, 2024 13:32
@akien-mga akien-mga changed the title Use existing plugin.cfg Use existing plugin.cfg in configuration dialog May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persistent additional data in plugin configuration files
3 participants