Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify Tween.set_parallel() #79758

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Clarify Tween.set_parallel() #79758

merged 1 commit into from
Feb 18, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jul 21, 2023

Addresses #74608 (comment)

@KoBeWi KoBeWi added this to the 4.2 milestone Jul 21, 2023
@KoBeWi KoBeWi requested a review from a team as a code owner July 21, 2023 18:18
@Mickeon
Copy link
Contributor

Mickeon commented Sep 13, 2023 •
edited
Loading

I fell under the same "trap" right now, so it would be nice to have this one looked at. Although I kind of have to agree, the behavior is a bit unorthodox.

@YuriSizov
Copy link
Contributor

YuriSizov commented Sep 15, 2023 •
edited
Loading

Yeah, I don't get it. It makes everything after and one before to run in parallel? I can see the logic behind it now, but without knowing that this is the case I'd be very surprised by this behavior.

@Mickeon
Copy link
Contributor

Mickeon commented Sep 15, 2023 •
edited
Loading

It feels buggy, but would be too late to somehow change now. I wouldn't hope others to completely disregard parallel tweens for this undocumented behavior

@YuriSizov YuriSizov modified the milestones: 4.2, 4.x Oct 30, 2023
@Mickeon
Copy link
Contributor

Mickeon commented Jan 26, 2024

How do we feel about this? I still believe this behavior is unorthodox, but it's better to document it than not doing anything.

Mickeon
Mickeon approved these changes Feb 18, 2024
View reviewed changes
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, Micky from 3 weeks ago: it is better to document it than not doing anything.

Although the current behavior is not exactly pretty.

@Mickeon Mickeon added cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Feb 18, 2024
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Feb 18, 2024
@akien-mga akien-mga merged commit 739cb2d into godotengine:master Feb 18, 2024
13 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the understandment branch February 18, 2024 23:19
@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.
Cherry-picked for 4.1.4.

@akien-mga akien-mga removed cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Mar 11, 2024
@Lippanon Lippanon mentioned this pull request Sep 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mickeon Mickeon Mickeon approved these changes

Assignees
No one assigned
Labels
discussion documentation enhancement
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
5 participants
@KoBeWi @Mickeon @YuriSizov @akien-mga @AThousandShips