Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exceptions for breakage introduced in RD barriers #79911

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Add exceptions for breakage introduced in RD barriers #79911

merged 1 commit into from
Aug 1, 2023

Conversation

BastiaanOlij
Copy link
Contributor

@BastiaanOlij BastiaanOlij commented Jul 26, 2023 •
edited
Loading

This PR makes a few minor changes to #77420 to:

  • make sure the existing enums BARRIER_MASK_COMPUTE and BARRIER_MASK_TRANSFER keep their original values
  • make sure that enums BARRIER_MASK_ALL_BARRIERS and BARRIER_MASK_NO_BARRIER are more future proof in case we add additional flags in the future.

Added exceptions to 4.0-stable-expected where applicable.

@BastiaanOlij BastiaanOlij added this to the 4.2 milestone Jul 26, 2023
@BastiaanOlij BastiaanOlij self-assigned this Jul 26, 2023
@BastiaanOlij
Copy link
Contributor Author

Just waiting on CI to finish so we know the breakage exceptions I need to add...

@BastiaanOlij BastiaanOlij force-pushed the fix_barrier_breakage branch 2 times, most recently from dd72026 to 98bcb64 Compare July 26, 2023 02:54
@BastiaanOlij BastiaanOlij marked this pull request as ready for review July 26, 2023 02:54
@BastiaanOlij BastiaanOlij requested review from a team as code owners July 26, 2023 02:54
clayjohn
clayjohn approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This should minimize compat breakage if anyone is relying on these barriers and it gets rid of our annoying errors

dsnopek
dsnopek approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me as well! Thanks!

raulsntos
raulsntos reviewed Jul 26, 2023
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know what these barrier flags are, so I added some comments only regarding compatibility.

It does look like it will break compat less and that looks like a good thing.

doc/classes/RenderingDevice.xml Show resolved Hide resolved
doc/classes/RenderingDevice.xml Show resolved Hide resolved
doc/classes/RenderingDevice.xml Show resolved Hide resolved
@YuriSizov YuriSizov merged commit cc1ee3e into godotengine:master Aug 1, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@pkdawson pkdawson mentioned this pull request Sep 5, 2023
Merged
@BastiaanOlij BastiaanOlij deleted the fix_barrier_breakage branch July 10, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

@raulsntos raulsntos raulsntos approved these changes

@dsnopek dsnopek dsnopek approved these changes

Assignees

@BastiaanOlij BastiaanOlij

Labels
bug topic:rendering
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
5 participants
@BastiaanOlij @YuriSizov @dsnopek @raulsntos @clayjohn