Disable error condition for accessing safe rect #79937
Conversation
This PR removes the error-message, which is currently expected to happen. The task of correctly fixing the underlying problem of window popup closing is more complex, so this PR solves the immediate error-notification-problem.
Sauermann
force-pushed
the
fix-expected-safe-rect-error
branch
from
7d78b11
to
7fead97
Compare
|
I don't think this closes #79906. The problem that the user describes is not about having an error message or not. It's about the dialog closing immediately, rendering part of the UI unusable. Apparently, this is no longer the case in 4.2, but is a problem in 4.1. So it would be nice to identify which change fixed the issue so we could consider cherry-picking it. If it's not cherry-pickable, a fix for 4.1 directly would also be appreciated. That is unrelated to this PR, though. If you think we should hide the error for now and handle the case as valid, that's fine, we can change that. |
|
@YuriSizov Thank you for pointing this out. This is a good methodology for handling issues, that are no longer reproducible in master. I will try to keep that im mind, when I come across similar situations again. |
|
Thanks! |
This PR removes the error-message, which is currently expected to happen. The task of correctly fixing the underlying problem of embedded window popup closing is more complex, so this PR solves the immediate error-notification-problem.
See #79906