Delegate opening files for Rider to the RiderPathLocator NuGet package

[van800]

OpenFile (for Rider and Fleet) functionality is now managed by the JetBrains nuget.
When both Rider and Fleet are installed, Rider would be more preferable, which would fix #78832 (comment)

[RedworkDE]

LGTM with two caveats:

• I don't actually have Rider so I didn't test this, but the +1 for the line got removed. Does this open the correct line (watch out for C#: Fix line in OpenInExternalEditor #79404 when testing this)
• The name of this PR/commit is kinda non-descriptive and I think something along the lines of Delegate opening files in Rider to the Rider locator NuGet package would be better

[raulsntos]

Only some minor nitpicks, LGTM otherwise.

Also, don't forget to update the commit message, it's more important than the PR title since it's what shows up in the git history.

[raulsntos]

[...] the +1 for the line got removed. Does this open the correct line.

I assume they moved that to the NuGet package, but would be nice to confirm.

By the way, @van800 the NuGet package points to https://github.com/JetBrains/resharper-unity/ but it doesn't seem like that repository has the source code for the package (or maybe I'm looking at the wrong branch).

[van800]

[...] the +1 for the line got removed. Does this open the correct line.

I assume they moved that to the NuGet package, but would be nice to confirm.

By the way, @van800 the NuGet package points to https://github.com/JetBrains/resharper-unity/ but it doesn't seem like that repository has the source code for the package (or maybe I'm looking at the wrong branch).

It will get synchronized soon from the internal repo. I will post another message here, once that is done.

[van800]

That is in sync now https://github.com/JetBrains/resharper-unity/blob/net233/unity/PathLocator/PathLocator.csproj

[raulsntos]

Does this still work after #79404 has been merged? @RedworkDE was correct that now the code no longer adds 1 to the line number and RiderFileOpener doesn't seem to do it either:

https://github.com/JetBrains/resharper-unity/blob/21e2393e2a3825cb4fd7035e9ef6307bc3068502/unity/PathLocator/RiderFileOpener.cs#L25

So make sure it opens the file at the correct line number.

---

Also, can you rename the Rider option to include Fleet? Since it seems to support both. Something like this:

diff --git a/modules/mono/editor/GodotTools/GodotTools/GodotSharpEditor.cs b/modules/mono/editor/GodotTools/GodotTools/GodotSharpEditor.cs
index 622a155d37..8bda2706a5 100644
--- a/modules/mono/editor/GodotTools/GodotTools/GodotSharpEditor.cs
+++ b/modules/mono/editor/GodotTools/GodotTools/GodotSharpEditor.cs
@@ -538,7 +538,7 @@ namespace GodotTools
                 settingsHintStr += $",Visual Studio:{(int)ExternalEditorId.VisualStudio}" +
                                    $",MonoDevelop:{(int)ExternalEditorId.MonoDevelop}" +
                                    $",Visual Studio Code:{(int)ExternalEditorId.VsCode}" +
-                                   $",JetBrains Rider:{(int)ExternalEditorId.Rider}" +
+                                   $",JetBrains Rider and Fleet:{(int)ExternalEditorId.Rider}" +
                                    $",Custom:{(int)ExternalEditorId.CustomEditor}";
             }
             else if (OS.IsMacOS)
@@ -546,14 +546,14 @@ namespace GodotTools
                 settingsHintStr += $",Visual Studio:{(int)ExternalEditorId.VisualStudioForMac}" +
                                    $",MonoDevelop:{(int)ExternalEditorId.MonoDevelop}" +
                                    $",Visual Studio Code:{(int)ExternalEditorId.VsCode}" +
-                                   $",JetBrains Rider:{(int)ExternalEditorId.Rider}" +
+                                   $",JetBrains Rider and Fleet:{(int)ExternalEditorId.Rider}" +
                                    $",Custom:{(int)ExternalEditorId.CustomEditor}";
             }
             else if (OS.IsUnixLike)
             {
                 settingsHintStr += $",MonoDevelop:{(int)ExternalEditorId.MonoDevelop}" +
                                    $",Visual Studio Code:{(int)ExternalEditorId.VsCode}" +
-                                   $",JetBrains Rider:{(int)ExternalEditorId.Rider}" +
+                                   $",JetBrains Rider and Fleet:{(int)ExternalEditorId.Rider}" +
                                    $",Custom:{(int)ExternalEditorId.CustomEditor}";
             }
 

[van800]

Thank you, fixed both.

[raulsntos]

LGTM, but I haven't tested since I don't have Rider.

[akien-mga]

Thanks!