Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[String] Fix Unicode parsing error message encoding and related JSON tests. #79980

Merged
merged 1 commit into from
Aug 9, 2023
Merged

[String] Fix Unicode parsing error message encoding and related JSON tests. #79980

merged 1 commit into from
Aug 9, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jul 28, 2023 •
edited
Loading

  • Changes JSON valid Unicode test to actually use valid sequence (\u0000 is not valid).
  • Adds error print suppression to JSON invalid Unicode test.
  • Fixes encoding of the Unicode parsing error message string literal.

See #79806 (not fixing the main issue, but test issues were mentioned in comments).

@bruvzg bruvzg added this to the 4.2 milestone Jul 28, 2023
@bruvzg bruvzg requested review from a team as code owners July 28, 2023 09:30
@Sauermann
Copy link
Contributor

I can confirm, that the PR removes the parsing error messages during tests. Can't say anything about the implementation.

@akien-mga akien-mga merged commit 835957b into godotengine:master Aug 9, 2023
@bruvzg bruvzg deleted the fix_test_str_errs branch August 9, 2023 13:23
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga mentioned this pull request Sep 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:core
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@bruvzg @Sauermann @akien-mga