Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add TileSet to TileMap #80038

Closed
wants to merge 1 commit into from

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jul 30, 2023

@groud
Copy link
Member

groud commented Jul 31, 2023

Thanks for the contribution! I would like to have a bit more people backing this proposal. I am not strictly against it but I see an annoying issue with it: Users might forget they are not working on their "common" TileSet and start to work on the automatically assigned TileSet. This might result in lost work as we have no way to merge two TileSet together.

I think I prefer the current situation a bit because, even if it's one step more to newcomers, it makes sure creating a new TileSet is what the users really wants. And also, when you build several maps, you should share TileSets quite often, so auto-assigning a new TileSet might not be the most useful.

@KoBeWi
Copy link
Member Author

KoBeWi commented Jul 31, 2023

tbh I'm not convinced of this change either and #77962 already made it clear how to add a TileSet.
I only opened this PR because I thought there are no drawbacks, but you make a good point.

@AThousandShips AThousandShips modified the milestones: 4.2, 4.3 Oct 26, 2023
@KoBeWi
Copy link
Member Author

KoBeWi commented Jan 1, 2024

Closing as this doesn't really bring any improvement. Most of the time you'll want to assign a TileSet file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants