Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in modulo error message. #80114

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

Deledrius
Copy link
Contributor

No description provided.

Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct, the term should be "Modulo".

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that those are the only occurrences of "Module" used for "Modulo" in a string.

For the record, this error also exists with Variant::OP_MODULE, but we can't change it without breaking compatibility and it's not a critical issue, so that one won't change (at least not before Godot 5).

@akien-mga akien-mga merged commit e48b999 into godotengine:master Aug 2, 2023
@akien-mga
Copy link
Member

Thanks!

@Deledrius Deledrius deleted the modulo_typo branch August 2, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants