Initialize View Frame Time estimates to match 120 FPS #80124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
enhancement
topic:editor
topic:3d
cherrypick:4.1
Calinou
force-pushed
the
3d-editor-frame-time-initialize-fps
branch
from
ca8537f
to
1f373e3
Compare
|
I think it looks a bit jarring for the numbers to start orange and then fade down. Maybe we should use a middleground like 8 ms to start so the numbers start green and have a reasonable value to scale up or down from |
Done 🙂 |
This prevents the estimation from being extremely high (close to 100,000 FPS) until enough time has passed to display an accurate estimation.
Calinou
force-pushed
the
3d-editor-frame-time-initialize-fps
branch
from
1f373e3
to
15b31f0
Compare
clayjohn
approved these changes
Aug 28, 2023
Calinou
changed the title
|
Thanks! |
|
Cherry-picked for 4.1.3. |
YuriSizov
removed
the
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When View Frame Time is freshly enabled, this prevents the estimation from being extremely high (close to 100,000 FPS) until enough time has passed to display an accurate estimation.
With #75512, this is still relevant for the CPU time and GPU time display.
Preview
Play the videos at 0.5× speed by right-clicking it and choosing the speed in the browser's context menu.
Before
simplescreenrecorder-2023-08-01_17.41.31.mp4
After
simplescreenrecorder-2023-08-01_17.43.03.mp4