Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Do not force redraw window background on mouse pass-through region change. #80153

Merged
merged 1 commit into from
Aug 2, 2023
Merged

[Windows] Do not force redraw window background on mouse pass-through region change. #80153

merged 1 commit into from
Aug 2, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Aug 2, 2023

  • Disables forced window redraw on region change (which can cause default bg color to show if Vulkan context is not updating fast enough).
  • Remove unnecessary region deletion.

After a successful call to SetWindowRgn, the system owns the region specified by the region handle hRgn. The system does not make a copy of the region. Thus, you should not make any further function calls with this region handle. In particular, do not delete this region handle. The system deletes the region handle when it no longer needed.

Fixes #80098

@bruvzg bruvzg requested a review from a team as a code owner August 2, 2023 07:43
@akien-mga akien-mga added this to the 4.2 milestone Aug 2, 2023
akien-mga
akien-mga approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@akien-mga akien-mga added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Aug 2, 2023
@akien-mga akien-mga merged commit dca12c2 into godotengine:master Aug 2, 2023
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg deleted the win_mouse_pass_redraw_fix branch August 2, 2023 11:28
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.3.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug platform:windows topic:porting
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

"window_set_mouse_passthrough" With Transparent Window causes white flickering during runtime
3 participants
@bruvzg @akien-mga @YuriSizov