Usage notes for DEV_ASSERT macro #80156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawnjelly
changed the title
lawnjelly
force-pushed
the
dev_assert_note
branch
from
852c9aa to
e0d10fc
Compare
RandomShaper
reviewed
Aug 2, 2023
lawnjelly
force-pushed
the
dev_assert_note
branch
2 times, most recently
from
eae4bde to
9172303
Compare
RandomShaper
approved these changes
Aug 2, 2023
clayjohn
reviewed
Aug 2, 2023
Make it more clear that DEV_ASSERT is only to be used in specific cases.
lawnjelly
force-pushed
the
dev_assert_note
branch
from
9172303 to
85c3017
Compare
clayjohn
approved these changes
Aug 2, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it more clear that DEV_ASSERT is only to be used in specific cases.
Notes
DEV_ASSERTin places better suited to other error macros (e.g. Refactormouse_enteredandmouse_exitedsignals #67791 ), this should make it more clear when to use, both for contributors and production team.coreteam.