Document that Input.is_action_* should not be used during input-handling
#80185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothyqiu
reviewed
Aug 3, 2023
Sauermann
force-pushed
the
fiix-action-event-doc
branch
2 times, most recently
from
fe84fb9
to
cf2759b
Compare
AThousandShips
approved these changes
Nov 10, 2023
…dling In most cases `InputEvent.is_action*` is more appropriate during input-handling.
akien-mga
force-pushed
the
fiix-action-event-doc
branch
from
be15e6a
to
0baebed
Compare
|
I committed the suggestions and squashed myself as I know Sauermann was busy. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most cases
InputEvent.is_action*is more appropriate during input-handling.close #80158 which shows this misunderstanding.