Fix autoswitch 2D/3D view when clicking on node with floating script editor #80307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Aug 9, 2023
akien-mga
approved these changes
Aug 9, 2023
akien-mga
added
the
cherrypick:4.1
akien-mga
reviewed
Aug 17, 2023
| @@ -274,6 +274,7 @@ class ScriptEditor : public PanelContainer { | |||
| Button *help_search = nullptr; | |||
| Button *site_search = nullptr; | |||
| Button *make_floating = nullptr; | |||
| bool floating_activated; | |||
There was a problem hiding this comment.
Set this to false here instead of in the constructor.
|
Superseded by #80647. |
akien-mga
added
archived
and removed
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #80015
Issue fixed :
When clicking on a node in the scene tree, editor autoswitch to 2D/3D view when script editor is not visible.
This behaviour is good until we use floating script editor. Because in this case, we can see both the script and the 2D/3D view and autoswitch is expected.
Fix proposal :
Check if editor script is floating and allow autoswitch to 2D/3D view when clicking in the scene tree.
Behaviour with non floating script is unchanged.
Before :
After the fix :