-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add handles to control Curve3D tilt #80329
Conversation
There are review comments that are hidden under the "conversations hidden" that you have missed Please try to apply them as a batch, to prevent restarting CI several times |
042a1f7
to
a3b4792
Compare
Done. Thanks for the tip! not a regular user of Github. |
32eb152
to
6c18f27
Compare
CC @TokageItLab @ajreckof who have been involved in reviewing or improving this plugin recently, IINM. |
5c18a9c
to
0e355ce
Compare
0e355ce
to
17ca090
Compare
ea6658e
to
a0e26f1
Compare
a0e26f1
to
a2ae833
Compare
a2ae833
to
27972e1
Compare
27972e1
to
38c5a41
Compare
38c5a41
to
46e395a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the code style problems were removed and seemed to work fine when I tested.
As for the feedback of usability, I suggest that the TiltHandle should be a different color than the InOut Handle (e.g. yellow line). Also it would be better to be able to change the radius from EditorSetting. Well, we can send the PR for these improvements later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code style looks good
Hi @akien-mga, is it possible to merge this PR earlier than 4.x? I'd like to start working on this proposal and usability improvement mentioned in @TokageItLab's review comment. But they depend on changes in this PR. |
Thanks! |
This PR add handles to control Curve3D tilt. The implementation of in, out handles are also revamped, as the original ones are too hacky, specifically the mapping between handle ids and control point ids.
tilt_handle_showcase.mov
The behaviour of this PR is similar with PR #68873, but
disks
are added to indicate the tilt handles trajectories, and an blue radial line is add to indicate the "natural" up vector before tilt.An internal helper method Curve3D::_get_posture_at_control_point() is added to facilitate tile handle implantation, it could be promoted to an public method if someone found it useful.
When a Path3D is modified by handles, the transform of PathFollow3D is not updated, hence the attached camera view also doesn't change. This issue is fixed by a related PR #80233, which makes tweaking camera easier.