C#: Add analyzer release tracking #80343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulsntos
commented
Aug 6, 2023
| @@ -380,19 +398,21 @@ ISymbol exportedMemberSymbol | |||
| category: "Usage", | |||
There was a problem hiding this comment.
I feel like GD0303 shouldn't be a diagnostic, since it's not an user error. It definitely shouldn't be Usage since it's not caused by incorrect usage of API, it's a developer error caused by incorrect implementation of the analyzer.
Previous discussion: #64731 (comment).
modules/mono/editor/Godot.NET.Sdk/Godot.SourceGenerators/Common.cs
Outdated
Show resolved
Hide resolved
raulsntos
force-pushed
the
dotnet/warnings/RS2008
branch
from
737b11f to
f2a880a
Compare
raulsntos
force-pushed
the
dotnet/warnings/RS2008
branch
2 times, most recently
from
ab92106 to
35ef0fc
Compare
3 tasks
Fixes diagnostic RS2008.
raulsntos
force-pushed
the
dotnet/warnings/RS2008
branch
from
35ef0fc to
f685c69
Compare
paulloz
approved these changes
Feb 20, 2024
|
GD0001 and GD0002 will continue to raise warnings (RS2003) until the following PR is merged. Or we can remove them from the tracking here, and have the other PR introduce them retroactively. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes diagnostic RS2008.