Dismiss currently visible or upcoming tooltips when pressing Escape #80364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sauermann
reviewed
Aug 7, 2023
There was a problem hiding this comment.
Have tested the PR and is solves the described problem for me.
I agree with the design to not set the event as handled, when the timer is active and the tooltip is not yet shown.
Please move the whole block a bit down after the drag-cancelling section, so that drag-cancelling takes precedence over tooltip-cancelling.
This is standard UI behavior in most applications out there.
Calinou
force-pushed
the
control-escape-dismiss-tooltips
branch
from
3a15f75
to
6307b0b
Compare
Done 🙂 I've tested the changes and it still works as expected. |
Sauermann
approved these changes
Aug 8, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is standard UI behavior in most applications out there.
Preview
The editor inspector's documentation tooltips already have a special case for being dismissable, but prior to this PR, the node would always be deselected when pressing Escape while a tooltip is visible.
simplescreenrecorder-2023-08-07_10.50.20.mp4