Remove use of std::string in test
#80422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
commented
Aug 8, 2023
AThousandShips
force-pushed
the
shader_test_fix
branch
from
6ed9e56
to
d7c095b
Compare
AThousandShips
changed the title
std::string with String in teststd::string with Vector in test
bruvzg
reviewed
Aug 9, 2023
FYI, "Fixes" should come directly before the issue number to work as a closing keyword (edited the OP). |
Avoiding using the standard library here
AThousandShips
force-pushed
the
shader_test_fix
branch
from
d7c095b
to
6ca1432
Compare
AThousandShips
changed the title
std::string with Vector in teststd::string in test
akien-mga
approved these changes
Aug 9, 2023
|
Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can alternatively include
<string>but since this would be the only place in the source usingstd::stringsave for the glsl module and the windows platform I'll lean to thisThe only other places
std::stringis used are (excludingthirdparty/):modules/glslang/register_types.cppplatform/windows/crash_handler_windows.cppFixes: #80421