Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS] Fix missing mouse exit events on window close. #80439

Merged
merged 1 commit into from
Aug 9, 2023
Merged

[macOS] Fix missing mouse exit events on window close. #80439

merged 1 commit into from
Aug 9, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Aug 9, 2023

Same as #80279 and Windows counterpart.

@bruvzg bruvzg added this to the 4.2 milestone Aug 9, 2023
@bruvzg bruvzg requested a review from a team as a code owner August 9, 2023 07:26
Sauermann
Sauermann approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@Sauermann Sauermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation regarding send_window_event looks good to me, but I can't test it and I'm not familiar with macOS-specifics.

@akien-mga akien-mga merged commit 11ea4dc into godotengine:master Aug 9, 2023
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg deleted the macos_mouse_enter_exit branch August 9, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sauermann Sauermann Sauermann approved these changes

Assignees
No one assigned
Labels
bug platform:macos topic:porting
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@bruvzg @akien-mga @Sauermann