-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix get_method
from named lambda
#80506
Conversation
func test():
pass
@rpc
func test_rpc():
pass
func _ready() -> void:
var l1 := func (): pass
var l2 := func lambda(): pass
print(test.get_method()) # test
print(test_rpc.get_method()) # Error: Can't get method on CallableCustom "Node(node.gd)::test_rpc (rpc)".
print(l1.get_method()) # <anonymous lambda>
print(l2.get_method()) # lambda |
You should squash the commits into one, according to the docs.
godot/doc/classes/Callable.xml Lines 138 to 143 in 4714e95
I'm not sure about that, just noticed. let the C# team decide. |
0173d6a
to
793cc08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct.
Thanks! |
Cherry-picked for 4.1.3. |
Fix #80434
Snippet used:
Before PR:
After PR: